Hi Octavian, > >> +void bt_sock_reclassify_lock(struct sock *sk, int proto) > >> { > >> - struct sock *sk = sock->sk; > >> - > >> if (!sk) > >> return; > > > > Why are we keeping the !sk check here if we already hand in the sk. It > > is most likely checked by the caller already. > > > > In rfcomm_sock_create (called from bt_sock_create) sock->sk can be set > to NULL so I think we should keep the check. it has been too long since I looked at this part of the code. You need to walk me through it why this is still true. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html