On Sat, Jan 21, 2012 at 6:44 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Octavian,
Hi Marcel,
>> Change-Id: I0e5e395e579c20d29d1fb3aef862c011a9031225
>
> No Change-Id please. This is not some Gerrit review thing.
>
Sorry about that, it slipped :) I will resend the patch with the
change id removed.
>> +void bt_sock_reclassify_lock(struct sock *sk, int proto)
>> {
>> - struct sock *sk = sock->sk;
>> -
>> if (!sk)
>> return;
>
> Why are we keeping the !sk check here if we already hand in the sk. It
> is most likely checked by the caller already.
>
In rfcomm_sock_create (called from bt_sock_create) sock->sk can be set
to NULL so I think we should keep the check.
Thanks!
Tavi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
