Re: [PATCH obexd 4/4] Simplify code for calling mime driver flush()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Slawomir,

On Thu, Oct 6, 2011 at 11:21 AM, Slawomir Bochenski <lkslawek@xxxxxxxxx> wrote:
>
> obexd works as it should. The code is coping with this by doing a
> buffering on behalf of a service driver if the service driver is not
> using chkput. So from the service perspective it will be still put,
> open, write, as the actual writing to mime driver is started at
> obex_put_stream_start.

Except that we should not buffer more than MTU size, also this is
completely the opposite of what we should be doing which is to copy
buffers as little as possible. As for broken I mean the design is
broken since if the service does not implement .put obexd should
return not implemented right in the first packet, actually .put is
completely useless right now since it is basically as calling a .flush
but it does useless checks.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux