Hi Antonio, > > > > lib/bluetooth.c::batostr() is returning the bdaddr reversed, fix this > > > > and put more arguments on the same line to look more like ba2str(). > > > > > > this would be breaking existing API. So NAK. > > > > > > > OK, but it is still weird that batostr() and ba2str() work differently. > > batostr() has no in-tree user AFAICS, just FYI. > > > > Would a batostr_bis() which behaves more like ba2str() wrt. bdaddr > ordering be accepted, or do I just duplicate the code in my function? just simply use ba2str. With batostr you have potential side effects with the lifetime of the return memory anyway. That is also the reason why none of the official BlueZ utilities or the daemon uses it. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
