Re: [PATCH BlueZ] Fix batostr(): return the bdaddr in the right order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Sep 2011 21:08:12 +0200
Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote:

> On Wed, 14 Sep 2011 19:53:45 +0200
> Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> 
> > Hi Antonio,
> > 
> > > lib/bluetooth.c::batostr() is returning the bdaddr reversed, fix this
> > > and put more arguments on the same line to look more like ba2str().
> > 
> > this would be breaking existing API. So NAK.
> > 
> 
> OK, but it is still weird that batostr() and ba2str() work differently.
> batostr() has no in-tree user AFAICS, just FYI.
> 

Would a batostr_bis() which behaves more like ba2str() wrt. bdaddr
ordering be accepted, or do I just duplicate the code in my function?

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Attachment: pgp2fAjG7ze3B.pgp
Description: PGP signature


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux