Hi Luiz,
* Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> [2011-08-19 10:13:16 +0300]:
> Hi Gustavo,
>
> On Thu, Aug 18, 2011 at 11:10 PM, Gustavo F. Padovan
> <padovan@xxxxxxxxxxxxxx> wrote:
> > From: "Gustavo F. Padovan" <padovan@xxxxxxxxxxxxxx>
> >
> > Use port->msg has the same effect of using port->io.
> > ---
> > serial/port.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/serial/port.c b/serial/port.c
> > index 3f041a6..bc4b4ea 100644
> > --- a/serial/port.c
> > +++ b/serial/port.c
> > @@ -149,7 +149,7 @@ static int port_release(struct serial_port *port)
> > int err = 0;
> >
> > if (port->id < 0) {
> > - if (port->io) {
> > + if (port->msg) {
> > g_io_channel_shutdown(port->io, TRUE, NULL);
> > g_io_channel_unref(port->io);
> > port->io = NULL;
>
> They may have the same effect but I would maintain the current one
> since we are only using port->io and changing it to port->msg may be
> unclear when reading the code without knowing the behavior.
Yes, but I want to change the behavior of port->io since I don't to create
another struct member to mantain the IO channel.
Maybe we can keep it here, I'll check the code.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
