Re: [PATCH 3/5] serial: use port->msg to track rfcomm connection procedure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Thu, Aug 18, 2011 at 11:10 PM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> From: "Gustavo F. Padovan" <padovan@xxxxxxxxxxxxxx>
>
> Use port->msg has the same effect of using port->io.
> ---
>  serial/port.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/serial/port.c b/serial/port.c
> index 3f041a6..bc4b4ea 100644
> --- a/serial/port.c
> +++ b/serial/port.c
> @@ -149,7 +149,7 @@ static int port_release(struct serial_port *port)
>        int err = 0;
>
>        if (port->id < 0) {
> -               if (port->io) {
> +               if (port->msg) {
>                        g_io_channel_shutdown(port->io, TRUE, NULL);
>                        g_io_channel_unref(port->io);
>                        port->io = NULL;

They may have the same effect but I would maintain the current one
since we are only using port->io and changing it to port->msg may be
unclear when reading the code without knowing the behavior.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux