Re: [PATCH 11/23] avrcp: handle SetPlayerApplicationSettingValue pdu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Mon, Aug 8, 2011 at 5:31 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Fri, Aug 5, 2011 at 9:15 PM, Lucas De Marchi
> <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> +static void append_variant(DBusMessageIter *iter, int type, void *val)
>> +{
>> +       DBusMessageIter value;
>> +       char sig[2] = { type, '\0' };
>> +
>> +       dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, sig, &value);
>> +
>> +       dbus_message_iter_append_basic(&value, type, val);
>> +
>> +       dbus_message_iter_close_container(iter, &value);
>> +}
>
> There should be possible to use dict_append_entry(src/dbus-common.h)
> here, isn't it?
>
>> +static dbus_bool_t emit_setting_changed(DBusConnection *conn,
>> +                                               const char *path,
>> +                                               const char *interface,
>> +                                               const char *name,
>> +                                               int type, void *value)
>> +{
>> +       DBusMessage *signal;
>> +       DBusMessageIter iter;
>> +
>> +       signal = dbus_message_new_signal(path, interface, "SettingChanged");
>> +
>> +       if (!signal) {
>> +               error("Unable to allocate new %s.SettingChanged signal",
>> +                               interface);
>> +               return FALSE;
>> +       }
>> +
>> +       dbus_message_iter_init_append(signal, &iter);
>> +
>> +       dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &name);
>> +
>> +       append_variant(&iter, type, value);
>> +
>> +       return g_dbus_send_message(conn, signal);
>> +}
>> +
>
> I wonder if the settings cannot use PropertyChanged instead?

If I use PropertyChanged, I can use emit_property_changed(). Then I
don't need this method. I'll do it, thanks.


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux