Hi Slawek,
On Tue, Jun 14, 2011, Slawomir Bochenski wrote:
> On Tue, Jun 14, 2011 at 8:33 AM, Luiz Augusto von Dentz
> <luiz.dentz@xxxxxxxxx> wrote:
> >> + if (ret == -EAGAIN) {
> >> + suspend_get(os, os->obex, os->obj);
> >> + } else if (ret < 0) {
> >> os_set_response(os->obj, err);
> >> OBEX_CancelRequest(os->obex, TRUE);
> >> - } else
> >> + } else {
> >> OBEX_ResumeRequest(os->obex);
> >> + }
> >
> > One line statements do not need {
> Kernel coding style states that this is not true when another branch
> in the if-else has more than one statement. Then braces should be used
> for all branches.
> >
> >> - return FALSE;
> >> + if (os->suspended)
> >> + return TRUE;
> >> + else
> >> + return FALSE;
> >> }
> >
> > I guess here you can just return os->suspended.
> I guess I can.
I've applied 1/4 and 2/4 since they seem fine. Luiz had some more
comments on 3/4 (I assume he'll send an email soon) and I still didn't
see an update on 4/4 to address this coding style issue Luiz pointed
out.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
