Hi Waldek, On Wed, Jun 01, 2011, Waldemar.Rymarkiewicz@xxxxxxxxx wrote: > You mentioned that the check should be done in kernel as well. > However, mgmt API is like mgmt_pincode_replay and > mgmt_pincode_neg_replay what means that I should do a check (secure == > 1 && pinlen !=16) on mgmt_pincode_replay and if the pin is in fact not > secure then send pincode_neg_replay to the controller. > > In that case we could skipp checking in bluez at all to avoid double > checking, but it's fine if we do so. > > What about replaceing mgmt_pincode_replay and mgmt_pincode_neg_replay > with one mgmt_pincode_replay + error field in the struct to indicate > user space succeded or not. This way the checking could be done only > in the kernel I guess. I prefer to have two separate mgmt commands (this is consistent both with HCI and with the SSP related commands) and it's fine to have the check only on the kernel side (there's really no practical difference between one command with an error field or two separate commands). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
