Hi Johan, >struct authentictation_req (device->authr) is the right place >to store this value since it's bound is to the lifetime of the >authentication request, whereas struct btd_device isn't. Also, >as previously mentioned the type should be gboolean and not uint8_t. > You mentioned that the check should be done in kernel as well. However, mgmt API is like mgmt_pincode_replay and mgmt_pincode_neg_replay what means that I should do a check (secure == 1 && pinlen !=16) on mgmt_pincode_replay and if the pin is in fact not secure then send pincode_neg_replay to the controller. In that case we could skipp checking in bluez at all to avoid double checking, but it's fine if we do so. What about replaceing mgmt_pincode_replay and mgmt_pincode_neg_replay with one mgmt_pincode_replay + error field in the struct to indicate user space succeded or not. This way the checking could be done only in the kernel I guess. Can you comment on my thoughts? Waldek -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
