Re: [PATCH 2/6] Bluetooth: Create l2cap_chan_send()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Thu, May 12, 2011 at 1:32 AM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> +               } else {
> +               /* Segment SDU into multiples PDUs */

Given that you are moving code around, can you fix the indentation
error on the comment above?

> +                       err = l2cap_sar_segment_sdu(chan, msg, len);
> +                       if (err < 0)
> +                               return err;
> +               }
> +
> +               if (chan->mode == L2CAP_MODE_STREAMING) {
> +                       l2cap_streaming_send(chan);
> +                       err = len;
> +                       break;
> +               }
> +
> +               if ((chan->conn_state & L2CAP_CONN_REMOTE_BUSY) &&
> +                               (chan->conn_state & L2CAP_CONN_WAIT_F)) {
> +                       err = len;
> +                       break;
> +               }
> +               err = l2cap_ertm_send(chan);
> +
> +               if (err >= 0)
> +                       err = len;
> +               break;

Also, it makes more sense to have an empty line above
l2cap_ertm_send(), and remove the empty line below it.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux