Re: [PATCH 3/6] Bluetooth: Add chan->link_type struct member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Thu, May 12, 2011 at 1:32 AM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> @@ -204,8 +204,8 @@ static int l2cap_sock_connect(struct socket *sock, struct sockaddr *addr, int al
>        }
>
>        /* PSM must be odd and lsb of upper byte must be 0 */
> -       if ((__le16_to_cpu(la.l2_psm) & 0x0101) != 0x0001 &&
> -                               sk->sk_type != SOCK_RAW && !la.l2_cid) {
> +       if ((__le16_to_cpu(la.l2_psm) & 0x0101) != 0x0001 && !la.l2_cid &&
> +                                       chan->link_type == L2CAP_LINK_RAW) {

There seems to be a typo here:

Original: sk->sk_type != SOCK_RAW
New: chan->link_type == L2CAP_LINK_RAW

Should it be != instead?

>                err = -EINVAL;
>                goto done;
>        }

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux