Re: Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Filip,

> Structures "l2cap_conninfo" and "rfcomm_conninfo" have one padding
> byte each. This byte in "cinfo" is copied to userspace uninitialized.
> 
> patch no.1:
> -- cut --
> --- a/net/bluetooth/l2cap_sock.c        2011-05-04 03:59:13.000000000 +0100
> +++ b/net/bluetooth/l2cap_sock.c        2011-05-08 18:57:20.000000000 +0100
> @@ -446,6 +446,7 @@ static int l2cap_sock_getsockopt_old(str
>                         break;
>                 }
> 
> +               memset(&cinfo, 0, sizeof(cinfo));
>                 cinfo.hci_handle = l2cap_pi(sk)->conn->hcon->handle;
>                 memcpy(cinfo.dev_class, l2cap_pi(sk)->conn->hcon->dev_class, 3);

nice catch, but please create a patch via git format-patch and don't
forget a Signed-off-by line.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux