Hi Dmitriy, On Thu, Mar 17, 2011, Dmitriy Paliy wrote: > On Wed, 2011-03-16 at 14:01 +0200, ext Dmitriy Paliy wrote: > > 'Protocol not supported' error code is added to registeration of A2DP > > end-points. Error response org.bluez.Error.NotSupported instead of > > org.bluez.Error.InvalidArguments is used when SEP registration fails > > due to disabled corresponding interface in audio.conf. > > Seems like there were some comment about this patch that I missed. Could > anybody post a reply with them to this email? The main concern raised on IRC was about the convention of returning an integer error through a pointer parameter instead of the return value of the function. Usually it's better to have integer errors in the return value, but as the main purpose of this function is to create and return and object and checking for the exact error is a secondary concern (which isn't always needed). So I think it's kind of ok in this case and I've therefore pushed the patch upstream. It'd be nice if we had similar macros as the kernel has for encoding POSIX errno's into a pointer value. Then this kind of issue wouldn't exist. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
