Hi Bruna,
On Wed, Mar 16, 2011, Bruna Moreira wrote:
> +gboolean g_attrib_set_buffer(GAttrib *attrib, int mtu)
> +{
> + if (mtu < ATT_DEFAULT_LE_MTU)
> + mtu = ATT_DEFAULT_LE_MTU;
> +
> + if (mtu > ATT_MAX_MTU)
> + mtu = ATT_MAX_MTU;
> +
> + if (!bt_io_set(attrib->io, BT_IO_L2CAP, NULL,
> + BT_IO_OPT_OMTU, mtu,
> + BT_IO_OPT_INVALID))
> + return FALSE;
> +
> + attrib->buf = g_realloc(attrib->buf, mtu);
> +
> + attrib->buflen = mtu;
> +
> + return TRUE;
> +}
Wouldn't g_attrib_set_mtu make more sense for the name of this function?
Since it's named symmetrically to the _get version one would expect it
to take a buffer as an input parameter, but it's not doing that.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
