Hi Krzysztof,
On 12/11/2024 5:48 PM, Krzysztof Kozlowski wrote:
> On 11/12/2024 10:39, Cheng Jiang (IOE) wrote:
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> index 7bb68311c..2782d2325 100644
>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> @@ -101,7 +101,10 @@ properties:
>>>> max-speed: true
>>>>
>>>> firmware-name:
>>>> - description: specify the name of nvm firmware to load
>>>> + description:
>>>> + If one item is present, specify the name of the NVM firmware to load.
>>>> + If two items are present, the first item specifies the name of the NVM,
>>>> + and the second specifies the name of the rampatch firmware to load.
>>>
>>> Don't repeat constraints in free form text. Use proper constraints so
>>> you can validate your DTS. And then actually do validate your DTS...
>>>
>> It seems unnecessary to add this description, so I will drop this change. Is that okay?
>
> You need to list the items and describe them. See how all other bindings
> do it.
>
The firmware names are not fixed strings; they vary depending on the chip, board, or platform.
How about the following description? Thank you!
firmware-name:
$ref: /schemas/types.yaml#/definitions/string
description: |
List of firmware names. The first item is the name of the NVM firmware
to load. The second item is the name of the rampatch firmware to load,
if present.
minItems: 1
maxItems: 2
> Best regards,
> Krzysztof
