RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Thu, 07 Nov 2024 00:55:05 +0100
Authentication-results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="X8KvauNM"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rXy4CBfQ"
Authentication-results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
Authentication-results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Cc: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>, Marcel Holtmann <marcel@xxxxxxxxxxxx>, Johan Hedberg <johan.hedberg@xxxxxxxxx>, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>, "linux-bluetooth@xxxxxxxxxxxxxxx" <linux-bluetooth@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Michael Kelley <mhklinux@xxxxxxxxxxx>
In-reply-to: <6acb24504a454638848dd9adff7cb5dc@AcuMS.aculab.com>
References: <20241028-open-coded-timeouts-v2-0-c7294bb845a1@linux.microsoft.com> <20241028-open-coded-timeouts-v2-1-c7294bb845a1@linux.microsoft.com> <87wmhq28o6.ffs@tglx> <CAMuHMdWFAgfgM0uCrG4uMz77-Y8CFSnpL-YM_VEFuvKTPNKZ5w@mail.gmail.com> <87ed3y255a.ffs@tglx> <6acb24504a454638848dd9adff7cb5dc@AcuMS.aculab.com>

On Wed, Nov 06 2024 at 22:19, David Laight wrote:
> From: Thomas Gleixner
>> Still the macro should be documented.
>
> I was wondering if it really had any purpose at all.
> It just obfuscates code, doesn't even make it smaller.

What is obfuscated here?

secs_to_jiffies() is clearly describing what this is about, while 5 * HZ
is not. Nothing in a driver has to care about the underlying conversion
of a time delta expressed in SI units to a jiffies based time delta.

Thanks,

        tglx

References:
- [PATCH v2 0/2] Converge on secs_to_jiffies()
  - From: Easwar Hariharan
- [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
  - From: Easwar Hariharan
- Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
  - From: Thomas Gleixner
- Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
  - From: Geert Uytterhoeven
- Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
  - From: Thomas Gleixner
- RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
  - From: David Laight

Prev by Date: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
Next by Date: Re: Bluetooth kernel BUG with Intel AX211 (regression in 6.1.83)
Previous by thread: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()
Next by thread: [bluez/bluez] fa1f2e: sink: clean up outstanding AVDTP requests if the s...
Index(es):
- Date
- Thread

[Index of Archives] [Bluez Devel] [Linux Wireless Networking] [Linux Wireless Personal Area Networking] [Linux ATH6KL] [Linux USB Devel] [Linux Media Drivers] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Big List of Linux Books]