From: Thomas Gleixner > Sent: 29 October 2024 17:25 > > On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: > > On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > >> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > >> > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > >> > index 1220f0fbe5bf..e5256bb5f851 100644 > >> > --- a/include/linux/jiffies.h > >> > +++ b/include/linux/jiffies.h > >> > @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m) > >> > } > >> > } > >> > > >> > +#define secs_to_jiffies(_secs) ((_secs) * HZ) > >> > >> Can you please make that a static inline, as there is no need for macro > >> magic like in the other conversions, and add a kernel doc comment which > >> documents this? > > > > Note that a static inline means it cannot be used in e.g. struct initializers, > > which are substantial users of "<value> * HZ". > > Bah. That wants to be mentioned in the change log then. > > Still the macro should be documented. I was wondering if it really had any purpose at all. It just obfuscates code, doesn't even make it smaller. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
