Hi, On Fri, Mar 11, 2011, Johan Hedberg wrote: > This would be similar to how we handle the telephony driver in BlueZ and > how the PBAP phonebook back-end is handled in obexd. I'm not saying this > as justification for the approach but just as a place to look for > examples. The main justification is to remove one unnecessary > abstraction layer (the numeric function id) and to remove the need to > fit each MAP request into the same C function signature (messages_open). > > Trying to fit everything into the same mold forces you to create very > generic structs like mas_request which then end up needing a > private_data pointer (for request specific data) Sorry, I mixed this with some other structs in your code that have this sort of private data and layering. However, the main point about telling the back-end which function to call indirectly through an integer instead of just calling the function directly remains (even if the function signatures would be the same or very similar). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
