Re: [PATCH v3 2/3] Bluetooth: hci_uart: Add support for Amlogic HCI UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2024/8/6 1:29, Krzysztof Kozlowski wrote:
On 02/08/2024 11:39, Yang Li via B4 Relay wrote:
From: Yang Li <yang.li@xxxxxxxxxxx>

...

+
+static const struct aml_device_data data_w155s2 = {
+     .iccm_offset = 256 * 1024,
+};
+
+static const struct aml_device_data data_w265s2 = {
+     .iccm_offset = 384 * 1024,
+};
+
+static const struct of_device_id aml_bluetooth_of_match[] = {
+     { .compatible = "amlogic,w155s2-bt", .data = &data_w155s2 },
+     { .compatible = "amlogic,w265s2-bt", .data = &data_w265s2 },
Your binding says these devices are compatible, but above suggests it is
not. Confusing.

Yes, the DT binding is incorrect. I will refer to broadcom-bluetooth.yaml to make the modifications as follows:

properties:
  compatible:
    oneOf:
      - items:
          - enum:
              - amlogic,w265s1-bt
              - amlogic,w265p1-bt
          - const: amlogic,w155s2-bt
      - enum:
          - amlogic,w155s2-bt
          - amlogic,w265s2-bt

Please let me know if these changes are acceptable or if there are any further adjustments needed.


Best regards,
Krzysztof





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux