Hi Paul,
Thanks for your comments.
>-----Original Message-----
>From: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
>Sent: Friday, May 17, 2024 3:42 PM
>To: K, Kiran <kiran.k@xxxxxxxxx>
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan,
>Chethan <chethan.tumkur.narayan@xxxxxxxxx>; Devegowda, Chandrashekar
><chandrashekar.devegowda@xxxxxxxxx>; Satija, Vijay <vijay.satija@xxxxxxxxx>;
>linux-bluetooth@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v3 2/3] Bluetooth: btintel_pcie: Fix irq leak
>
>Dear Kiran,
>
>
>Thank you for your patch.
>
>Am 17.05.24 um 11:54 schrieb Kiran K:
>> Free irq before releasing irq vector.
>
>Can the leak be detected somehow? How did you detect it?
dmesg shows traces about irq leak when the driver is unloaded.
>
>> Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe
>transport")
>> Signed-off-by: Kiran <kiran.k@xxxxxxxxx>
>
>Just a note, that your surname is missing too.
Ack.
>
>> ---
>> drivers/bluetooth/btintel_pcie.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>> index 8d282ee2322c..d8f82e0f6435 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -1329,6 +1329,12 @@ static void btintel_pcie_remove(struct pci_dev
>*pdev)
>> data = pci_get_drvdata(pdev);
>>
>> btintel_pcie_reset_bt(data);
>> + for (int i = 0; i < data->alloc_vecs; i++) {
>> + struct msix_entry *msix_entry;
>> +
>> + msix_entry = &data->msix_entries[i];
>> + free_irq(msix_entry->vector, msix_entry);
>> + }
>>
>> pci_free_irq_vectors(pdev);
>
>
>Kind regards,
>
>Paul
