Hi Kai, On Mon, May 20, 2024 at 4:10 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > This removes the bogus check for max > hcon->le_conn_max_interval since > the later is just the initial maximum conn interval not the maximum the > stack could support which is really 3200=4000ms. > > In order to pass GAP/CONN/CPUP/BV-05-C one shall probably enter values > of the following fields in IXIT that would cause hci_check_conn_params > to fail: > > TSPX_conn_update_int_min > TSPX_conn_update_int_max > TSPX_conn_update_peripheral_latency > TSPX_conn_update_supervision_timeout > > Link: https://github.com/bluez/bluez/issues/847 > Fixes: e4b019515f95 ("Bluetooth: Enforce validation on max value of connection interval") > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > --- > net/bluetooth/l2cap_core.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 5b509b767557..c49e0d4b3c0d 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -4647,13 +4647,7 @@ static inline int l2cap_conn_param_update_req(struct l2cap_conn *conn, > > memset(&rsp, 0, sizeof(rsp)); > > - if (max > hcon->le_conn_max_interval) { > - BT_DBG("requested connection interval exceeds current bounds."); > - err = -EINVAL; > - } else { > - err = hci_check_conn_params(min, max, latency, to_multiplier); > - } > - > + err = hci_check_conn_params(min, max, latency, to_multiplier); > if (err) > rsp.result = cpu_to_le16(L2CAP_CONN_PARAM_REJECTED); > else > -- > 2.45.1 I hope that doesn't break the testing you have done, you should really be setting the invalid values with use of the fields about and not use hcon->le_conn_max_interval as upper limit of the stack, for more details check the discussion at https://github.com/bluez/bluez/issues/847. -- Luiz Augusto von Dentz
