On 4/24/24 5:27 AM, Bartosz Golaszewski wrote:
On Wed, Apr 24, 2024 at 2:24 PM Wren Turkal <wt@xxxxxxxxxxxxxxxx> wrote:
That's OK, we have the first part right. Let's now see if we can reuse
patch 2/2 from Zijun.
I'm compiling it right now. Be back soon.
Well I doubt it's correct as it removed Krzysztof's fix which looks
right. If I were to guess I'd say we need some mix of both.
Patch 2/2 remove K's fix? I thought only 1/2 did that.
To be specific, I have applied your patch and Zijun's 2/2 only.
No, patch 1/2 from Zijun reverted my changes. Patch 2/2 removes
Krzysztof's changes and replaces them with a different if else. This
patch is a better alternative to Zijun's patch 1/2. For 2/2, I'll let
Krzysztof handle it.
Got it. Thx.
BTW, should this patch's commit message include the following?
Tested-by: "Wren Turkal" <wt@xxxxxxxxxxxxxxxx>
If so, please feel free to add it.
wt
--
You're more amazing than you think!
