Hi Johan,
On Wed, Feb 23, 2011 at 12:21 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> On Tue, Feb 22, 2011, Anderson Lizardo wrote:
>> +struct attribute;
>> +
>> +typedef uint8_t (*att_cb_t)(struct attribute *a, gpointer user_data);
>> +
>> struct attribute {
>> uint16_t handle;
>> uuid_t uuid;
>> int read_reqs;
>> int write_reqs;
>> + att_cb_t read_cb;
>> + att_cb_t write_cb;
>> + gpointer cb_user_data;
>> int len;
>> uint8_t data[0];
>> };
>
> I'm not really a fan of the needed forward declaration here. I can't
> find you using "att_cb_t" anywhere else in your patches, so how about
> just having the full type of the callbacks inside the struct definition
> and skip the typedef completely?
Sure, I'll drop the typedef and send a v3.
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
