Re: [PATCHv2 2/5] Initial Client Characteristic Configuration implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Wed, Feb 23, 2011 at 12:26 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> On Tue, Feb 22, 2011, Anderson Lizardo wrote:
>> +static uint8_t client_set_notifications(struct attribute *attr,
>> +                                                     gpointer user_data)
>> +{
>> +     struct gatt_channel *channel = user_data;
>> +     struct attribute *a, *last_chr_val = NULL;
>> +     uint16_t handle, cfg_val;
>> +     uuid_t uuid;
>> +     GSList *l;
>> +
>> +     cfg_val = att_get_u16(attr->data);
>> +
>> +     sdp_uuid16_create(&uuid, GATT_CHARAC_UUID);
>> +     for (l = database, handle = 0; l != NULL; l = l->next) {
>> +             a = l->data;
>
> The variable "a" is only used inside the for-loop so it should be
> declared inside it as well. I think you can move handle inside the loop
> as well as long as you declare it static (so it only gets initialized to
> 0 on the first iteration).

Both changes will be incorporated on the v3.

>
> Johan
>

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux