Hi Luiz,
> > > > @@ -2194,10 +2197,26 @@ static void btintel_get_fw_name_tlv(const
> > > struct intel_version_tlv *ver,
> > > > char *fw_name, size_t len,
> > > > const char *suffix) {
> > > > + const char *format;
> > > > /* The firmware file name for new generation controllers will be
> > > > * ibt-<cnvi_top type+cnvi_top step>-<cnvr_top type+cnvr_top step>
> > > > */
> > > > - snprintf(fw_name, len, "intel/ibt-%04x-%04x.%s",
> > > > + switch (ver->cnvi_top & 0xfff) {
> > > > + /* Only Blazar product supports downloading of intermediate
> loader
> > > > + * image
> > > > + */
> > > > + case CNVI_BLAZARI:
> > > > + if (ver->img_type == IMG_BOOTLOADER)
> > > > + format = "intel/ibt-%04x-%04x-iml.%s";
> > >
> > > Shouldn't iml be the extension rather than the name? Like in
> > > intel/ibt-0090- 0291.iml which you can probably achieve by just
> > > replacing suffix, that said this function seems to be called with
> > > .ddc as suffix as well so I assume there is
> >
> > I feel it's better to keep the extension as sfi as the image format for IML and
> OP binaries are same.
>
> So sfi and ddc are file formats? The only thing Ive found was:
>
> https://filext.com/file-extension/SFI
>
> They sound more like binary blobs, .bin, or image files .img, but we choose to
> distinct them via file extension, thus why Is suggested to use .iml.
>
When I said format I was referring to the placement of INIT, DATA, KEY segments. Sorry if it sounds confusing. Both the images follow the same format and firmware download process is also same.
> > > some check preventing it to be called while version is IMG_BOOTLOADER?
> > There is no such restriction. The same function gets called even when
> version is IMG_BOOTLOADER. Inside this function we check for product and
> version to decide whether to load IML or OP image.
>
> Wouldn't we end up having *iml.ddc then?
>
No. ddc is only for operational image.
> > >
> > > > + else
> > > > + format = "intel/ibt-%04x-%04x.%s";
> > > > + break;
Thanks,
Kiran
