Re: [PATCH BlueZ 3/3] shared/ccp: Add initial code for Call Control Profile for Client Role.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[CC: -<ravishankar.sriv@xxxxxxxxx>, 550 #5.1.0 Address rejected. (in reply to RCPT TO command)]

Am 12.02.24 um 13:23 schrieb Paul Menzel:
Dear Ajay,


Thank you very much for the patches.


Am 12.02.24 um 17:17 schrieb Ajay KV:

It’d be great, if you wrote a commit message with information about CCP and how this is implemented and can be tested.

(Also, I’d remove the dot/period from the end of the commit message summary (also in patch 2/3).

---
  Makefile.am      |    1 +
  src/shared/ccp.c | 1147 ++++++++++++++++++++++++++++++++++++++++++++++
  src/shared/ccp.h |   45 ++
  3 files changed, 1193 insertions(+)
  create mode 100644 src/shared/ccp.c
  create mode 100644 src/shared/ccp.h

diff --git a/Makefile.am b/Makefile.am
index 2b1b9acdf825..fdffdc478a16 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -230,6 +230,7 @@ shared_sources = src/shared/io.h src/shared/timeout.h \
              src/shared/micp.c src/shared/micp.h \
              src/shared/csip.c src/shared/csip.h \
              src/shared/bass.h src/shared/bass.c \
+            src/shared/ccp.h src/shared/ccp.c \
              src/shared/lc3.h src/shared/tty.h
  if READLINE
diff --git a/src/shared/ccp.c b/src/shared/ccp.c
new file mode 100644
index 000000000000..9089779603bf
--- /dev/null
+++ b/src/shared/ccp.c
@@ -0,0 +1,1147 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
+/*
+ *
+ *  BlueZ - Bluetooth protocol stack for Linux
+ *
+ *  Copyright (C) 2022  Intel Corporation. All rights reserved.

Was this just copied, or was it really written in 2022?

+ *
+ */
+
+#define _GNU_SOURCE
+#include <inttypes.h>
+#include <string.h>
+#include <stdlib.h>
+#include <stdbool.h>
+#include <unistd.h>
+#include <errno.h>

[…]

diff --git a/src/shared/ccp.h b/src/shared/ccp.h
new file mode 100644
index 000000000000..809986c2601a
--- /dev/null
+++ b/src/shared/ccp.h
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+/*
+ *
+ *  BlueZ - Bluetooth protocol stack for Linux
+ *
+ *  Copyright (C) 2020  Intel Corporation. All rights reserved.
+ *
+ */

Ditto.

[…]


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux