This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=825164 ---Test result--- Test Summary: CheckPatch FAIL 1.79 seconds GitLint FAIL 0.89 seconds BuildEll PASS 24.03 seconds BluezMake PASS 687.75 seconds MakeCheck PASS 12.21 seconds MakeDistcheck PASS 162.46 seconds CheckValgrind PASS 225.62 seconds CheckSmatch PASS 331.69 seconds bluezmakeextell PASS 108.23 seconds IncrementalBuild PASS 1945.91 seconds ScanBuild PASS 939.98 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script Output: [BlueZ,1/3] lib/uuid: Add support to compare 16bit uuids WARNING:LEADING_SPACE: please, no spaces at the start of a line #90: FILE: lib/uuid.c:126: + if (!uuid1 || (uuid1->type != BT_UUID16))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (2, 4) #90: FILE: lib/uuid.c:126: + if (!uuid1 || (uuid1->type != BT_UUID16)) + return 0; WARNING:LEADING_SPACE: please, no spaces at the start of a line #91: FILE: lib/uuid.c:127: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #93: FILE: lib/uuid.c:129: + return (uuid1->value.u16 == uuid2);$ /github/workspace/src/src/13552944.patch total: 0 errors, 4 warnings, 22 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13552944.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role. WARNING:LEADING_SPACE: please, no spaces at the start of a line #305: FILE: src/shared/ccp.c:202: + void *user_data, bt_ccp_destroy_func_t destroy)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #361: FILE: src/shared/ccp.c:258: + &uuid, BT_ATT_PERM_READ,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #362: FILE: src/shared/ccp.c:259: + BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_NOTIFY,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #363: FILE: src/shared/ccp.c:260: + ccs_call_state_read, NULL, ccs);$ WARNING:LONG_LINE: line length of 81 exceeds 80 columns #375: FILE: src/shared/ccp.c:272: + ccs->bearer_technology = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 87 exceeds 80 columns #385: FILE: src/shared/ccp.c:282: + ccs->bearer_uri_schemes_list = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 87 exceeds 80 columns #402: FILE: src/shared/ccp.c:299: + ccs->signal_reporting_intrvl = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 81 exceeds 80 columns #410: FILE: src/shared/ccp.c:307: + ccs->current_call_list = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 81 exceeds 80 columns #437: FILE: src/shared/ccp.c:334: + ccs->target_bearer_uri = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 84 exceeds 80 columns #454: FILE: src/shared/ccp.c:351: + ccs->call_ctrl_opt_opcode = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 88 exceeds 80 columns #456: FILE: src/shared/ccp.c:353: + BT_GATT_CHRC_PROP_WRITE | BT_GATT_CHRC_PROP_WRITE_WITHOUT_RESP | WARNING:LONG_LINE: line length of 84 exceeds 80 columns #462: FILE: src/shared/ccp.c:359: + ccs->call_ctrl_opt_opcode = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 82 exceeds 80 columns #469: FILE: src/shared/ccp.c:366: + ccs->termination_reason = gatt_db_service_add_characteristic(ccs->service, WARNING:LONG_LINE: line length of 82 exceeds 80 columns #596: FILE: src/shared/ccp.c:493: +static void ccp_cb_status_flag_notify(uint16_t value_handle, const uint8_t *value, WARNING:LEADING_SPACE: please, no spaces at the start of a line #601: FILE: src/shared/ccp.c:498: + DBG(ccp, "");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #621: FILE: src/shared/ccp.c:518: + DBG(ccp, "");$ WARNING:LONG_LINE: line length of 82 exceeds 80 columns #640: FILE: src/shared/ccp.c:537: +static void ccp_cb_bearer_name_notify(uint16_t value_handle, const uint8_t *value, WARNING:LONG_LINE: line length of 81 exceeds 80 columns #687: FILE: src/shared/ccp.c:584: +static void ccp_cb_call_state_notify(uint16_t value_handle, const uint8_t *value, WARNING:LONG_LINE: line length of 81 exceeds 80 columns #711: FILE: src/shared/ccp.c:608: +static void ccp_cb_incom_call_notify(uint16_t value_handle, const uint8_t *value, WARNING:LONG_LINE: line length of 85 exceeds 80 columns #731: FILE: src/shared/ccp.c:628: + if (!gatt_db_attribute_get_char_data(ccs->incoming_call, NULL, &value_handle, WARNING:LONG_LINE: line length of 82 exceeds 80 columns #749: FILE: src/shared/ccp.c:646: + if (!gatt_db_attribute_get_char_data(ccs->call_state, NULL, &value_handle, WARNING:LONG_LINE: line length of 89 exceeds 80 columns #767: FILE: src/shared/ccp.c:664: + if (!gatt_db_attribute_get_char_data(ccs->current_call_list, NULL, &value_handle, WARNING:LONG_LINE: line length of 83 exceeds 80 columns #785: FILE: src/shared/ccp.c:682: + if (!gatt_db_attribute_get_char_data(ccs->bearer_name, NULL, &value_handle, WARNING:LONG_LINE: line length of 90 exceeds 80 columns #803: FILE: src/shared/ccp.c:700: + if (!gatt_db_attribute_get_char_data(ccs->termination_reason, NULL, &value_handle, WARNING:LONG_LINE: line length of 83 exceeds 80 columns #821: FILE: src/shared/ccp.c:718: + if (!gatt_db_attribute_get_char_data(ccs->status_flag, NULL, &value_handle, WARNING:LONG_LINE: line length of 82 exceeds 80 columns #839: FILE: src/shared/ccp.c:736: + if (!gatt_db_attribute_get_char_data(ccs->bearer_uci, NULL, &value_handle, WARNING:LONG_LINE: line length of 89 exceeds 80 columns #857: FILE: src/shared/ccp.c:754: + if (!gatt_db_attribute_get_char_data(ccs->bearer_technology, NULL, &value_handle, WARNING:LONG_LINE: line length of 87 exceeds 80 columns #874: FILE: src/shared/ccp.c:771: + if (!gatt_db_attribute_get_char_data(ccs->signal_strength, NULL, &value_handle, WARNING:LONG_LINE: line length of 89 exceeds 80 columns #909: FILE: src/shared/ccp.c:806: + if (!gatt_db_attribute_get_char_data(ccs->target_bearer_uri, NULL, &value_handle, WARNING:LONG_LINE: line length of 87 exceeds 80 columns #927: FILE: src/shared/ccp.c:824: + if (!gatt_db_attribute_get_char_data(ccs->call_ctrl_point, NULL, &value_handle, WARNING:LEADING_SPACE: please, no spaces at the start of a line #943: FILE: src/shared/ccp.c:840: + DBG(ccp, "");$ WARNING:LONG_LINE: line length of 92 exceeds 80 columns #945: FILE: src/shared/ccp.c:842: + if (!gatt_db_attribute_get_char_data(ccs->call_ctrl_opt_opcode, NULL, &value_handle, WARNING:LONG_LINE: line length of 85 exceeds 80 columns #951: FILE: src/shared/ccp.c:848: + ccp->call_control_opt_opcode_id = bt_gatt_client_register_notify(ccp->client, WARNING:LONG_LINE: line length of 85 exceeds 80 columns #963: FILE: src/shared/ccp.c:860: + if (!gatt_db_attribute_get_char_data(ccs->friendly_name, NULL, &value_handle, WARNING:LONG_LINE: line length of 95 exceeds 80 columns #981: FILE: src/shared/ccp.c:878: + if (!gatt_db_attribute_get_char_data(ccs->signal_reporting_intrvl, NULL, &value_handle, WARNING:LONG_LINE: line length of 85 exceeds 80 columns #987: FILE: src/shared/ccp.c:884: + ccp->signal_reporting_intrvl_id = bt_gatt_client_register_notify(ccp->client, WARNING:LONG_LINE: line length of 95 exceeds 80 columns #999: FILE: src/shared/ccp.c:896: + if (!gatt_db_attribute_get_char_data(ccs->bearer_uri_schemes_list, NULL, &value_handle, WARNING:LONG_LINE: line length of 85 exceeds 80 columns #1005: FILE: src/shared/ccp.c:902: + ccp->bearer_uri_schemes_list_id = bt_gatt_client_register_notify(ccp->client, WARNING:LONG_LINE: line length of 81 exceeds 80 columns #1040: FILE: src/shared/ccp.c:937: + DBG(ccp, "Found Bearer Technology, handle 0x%04x", value_handle); WARNING:LONG_LINE: line length of 82 exceeds 80 columns #1110: FILE: src/shared/ccp.c:1007: + DBG(ccp, "Found Termination Reason, handle 0x%04x", value_handle); WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) #1270: FILE: src/shared/ccp.h:14: +#define __packed __attribute__((packed)) /github/workspace/src/src/13552946.patch total: 0 errors, 41 warnings, 1199 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13552946.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,2/3] lib/uuid: Add GTBS UUIDS for Call Control Profile. WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T3 Title has trailing punctuation (.): "[BlueZ,2/3] lib/uuid: Add GTBS UUIDS for Call Control Profile." [BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role. WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (82>80): "[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role." 1: T3 Title has trailing punctuation (.): "[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role." --- Regards, Linux Bluetooth
