Hi, On Thu, Feb 17, 2011 at 03:23:10PM +0100, ext Szymon Janc wrote: > Hi, > > > On Thu, Feb 17, 2011 at 02:16:35PM +0100, ext Szymon Janc wrote: > > > Signed-off-by: Szymon Janc <szymon.janc@xxxxxxxxx> > > > --- > > > net/bluetooth/mgmt.c | 7 +++---- > > > 1 files changed, 3 insertions(+), 4 deletions(-) > > > > Some kind of explanation why EIO is better than status would be nice. > > As I've mentioned in cover letter: Cover letters does not end up to git log. Proper description helps debugging later a much if we can easily determine why this was needed and what was the motivation for this patch. > It is not possible to distinguish in cmd status if error was from kernel > or from HCI. Since in mgmt only kernel sends HCI commands their errors > shouldn't be needed for userspace so report EIO to userspace on HCI error > (if HCI error is needed for debugging, logs can be added on kernel side) > > HCI status codes and kernel error codes overlaps i.e. one can't distinguish > if error was ENOMEM or HCI Command Disallowed as both have value 12. > > For userspace is should be enough to just know that HCI failed, not why. > (in fact, currently userspace is not able to determine error too...) This sounds reasonable to me. -- Ville -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
