Hi Luiz, to, 2023-08-24 kello 14:28 -0700, Luiz Augusto von Dentz kirjoitti: > Hi, > > On Thu, Aug 24, 2023 at 2:21 PM Luiz Augusto von Dentz > <luiz.dentz@xxxxxxxxx> wrote: > > > > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > > > This moves QoS related propertis to a single dictionary. > > --- > > doc/media-api.txt | 44 +++++++++++++++++++++----------------------- > > 1 file changed, 21 insertions(+), 23 deletions(-) > > > > diff --git a/doc/media-api.txt b/doc/media-api.txt > > index 3a0ec38e244d..9f2482e73ac1 100644 > > --- a/doc/media-api.txt > > +++ b/doc/media-api.txt > > @@ -816,42 +816,40 @@ Properties object Device [readonly] > > Linked transport objects which the transport is > > associated with. > > > > - byte CIG [ISO only, optional, experimental] > > + dict QoS [ISO only, optional, experimental] > > > > - Indicates configured QoS CIG. > > Only present when QoS is configured. > > > > - byte CIS [ISO only, optional, experimental] > > + Possible values for Unicast: > > > > - Indicates configured QoS CIS. > > - Only present when QoS is configured. > > + byte CIG > > > > - uint32 Interval [ISO only, optional, experimental] > > + Indicates configured QoS CIG. > > > > - Indicates configured QoS interval. > > - Only present when QoS is configured. > > + byte CIS > > > > - boolean Framing [ISO only, optional, experimental] > > + Only present when QoS is configured. > > > > - Indicates configured QoS framing. > > - Only present when QoS is configured. > > + uint32 Interval > > > > - byte PHY [ISO only, optional, experimental] > > + Indicates configured QoS interval. > > > > - Indicates configured QoS PHY. > > - Only present when QoS is configured. > > + boolean Framing While we are breaking things, it would be useful to unify this API with SelectProperties/SetConfiguration, where PHY is string "1M" or "2M" not byte. Can we make it byte everywhere? I think the enum ultimately comes from Core spec, so not sure the string names are that useful. > > > > - uint16 SDU [ISO only, optional, experimental] > > + Indicates configured QoS framing. > > > > - Indicates configured QoS SDU. > > - Only present when QoS is configured. > > + byte PHY > > > > - byte Retransmissions [ISO only, optional, experimental] > > + Indicates configured QoS PHY. > > > > - Indicates configured QoS retransmissions. > > - Only present when QoS is configured. > > + uint16 SDU > > > > - uint16 Latency [ISO only, optional, experimental] > > + Indicates configured QoS SDU. > > > > - Indicates configured QoS latency. > > - Only present when QoS is configured. > > + byte Retransmissions > > + > > + Indicates configured QoS retransmissions. > > + > > + uint16 Latency > > + > > + Indicates configured QoS latency. > > -- > > 2.41.0 > > Let me know if you have anything against doing these changes, this > will break backward compatibility but since they are still marked as > experimental we can still do these changes. I think it's fine if Pipewire targets BlueZ master branch as long as the feature is experimental. -- Pauli Virtanen
