Re: [BlueZ RFC] media-api: Make QoS a single property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 24, 2023 at 2:21 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> This moves QoS related propertis to a single dictionary.
> ---
>  doc/media-api.txt | 44 +++++++++++++++++++++-----------------------
>  1 file changed, 21 insertions(+), 23 deletions(-)
>
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index 3a0ec38e244d..9f2482e73ac1 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -816,42 +816,40 @@ Properties        object Device [readonly]
>                         Linked transport objects which the transport is
>                         associated with.
>
> -               byte CIG [ISO only, optional, experimental]
> +               dict QoS [ISO only, optional, experimental]
>
> -                       Indicates configured QoS CIG.
>                         Only present when QoS is configured.
>
> -               byte CIS [ISO only, optional, experimental]
> +                       Possible values for Unicast:
>
> -                       Indicates configured QoS CIS.
> -                       Only present when QoS is configured.
> +                       byte CIG
>
> -               uint32 Interval [ISO only, optional, experimental]
> +                               Indicates configured QoS CIG.
>
> -                       Indicates configured QoS interval.
> -                       Only present when QoS is configured.
> +                       byte CIS
>
> -               boolean Framing [ISO only, optional, experimental]
> +                               Only present when QoS is configured.
>
> -                       Indicates configured QoS framing.
> -                       Only present when QoS is configured.
> +                       uint32 Interval
>
> -               byte PHY [ISO only, optional, experimental]
> +                               Indicates configured QoS interval.
>
> -                       Indicates configured QoS PHY.
> -                       Only present when QoS is configured.
> +                       boolean Framing
>
> -               uint16 SDU [ISO only, optional, experimental]
> +                               Indicates configured QoS framing.
>
> -                       Indicates configured QoS SDU.
> -                       Only present when QoS is configured.
> +                       byte PHY
>
> -               byte Retransmissions [ISO only, optional, experimental]
> +                               Indicates configured QoS PHY.
>
> -                       Indicates configured QoS retransmissions.
> -                       Only present when QoS is configured.
> +                       uint16 SDU
>
> -               uint16 Latency [ISO only, optional, experimental]
> +                               Indicates configured QoS SDU.
>
> -                       Indicates configured QoS latency.
> -                       Only present when QoS is configured.
> +                       byte Retransmissions
> +
> +                               Indicates configured QoS retransmissions.
> +
> +                       uint16 Latency
> +
> +                               Indicates configured QoS latency.
> --
> 2.41.0

Let me know if you have anything against doing these changes, this
will break backward compatibility but since they are still marked as
experimental we can still do these changes.

-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux