Hi Luiz, On Wed, Apr 12, 2023 at 3:00 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > > Hi Steev, > > On Thu, Mar 30, 2023 at 9:35 AM Steev Klimaszewski <steev@xxxxxxxx> wrote: > > > > Hi Johan, > > > > On Thu, Mar 30, 2023 at 5:10 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > > > On Sun, Mar 26, 2023 at 06:38:10PM -0500, Steev Klimaszewski wrote: > > > > Add regulators, GPIOs and changes required to power on/off wcn6855. > > > > Add support for firmware download for wcn6855 which is in the > > > > linux-firmware repository as hpbtfw21.tlv and hpnv21.bin. > > > > > > > > Based on the assumption that this is similar to the wcn6750 > > > > > > > > Tested-on: BTFW.HSP.2.1.0-00538-VER_PATCHZ-1 > > > > > > > > Signed-off-by: Steev Klimaszewski <steev@xxxxxxxx> > > > > Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > > > Tested-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > > > --- > > > > Changes since v7: > > > > * None > > > > > > Only noticed now when Luiz applied the patches, but why did you drop my > > > reviewed-by and tested-by tags from this patch when submitting v8? > > > > > > For the record: > > > > > > Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > > > Oops, that wasn't intentional! I only meant to drop it on the dts bits > > as that part I wanted to make sure I got right based on your comments, > > my apologies! > > --steev > > This one seems to be causing a new warning: > > drivers/bluetooth/hci_qca.c:18 > 94:37: warning: unused variable 'qca_soc_data_wcn6855' [-Wunused-const-variable] > I had seen this as well and I just noticed that the others were marked as __maybe_unused and I forgot to. Will send a fix up for that! > -- > Luiz Augusto von Dentz -- steev
