Hi Johan, > > > -static int disable_esco = 0; > > > +static int disable_esco; > > > > I don't think this change is right. Can we be sure that disable_esco > > will be 0 by default? > > AFAIK we can since static variables are initialized to 0 by default. > However, I've understood that it's good style to have this > initialization explicit in the code so imho the code should be left as > it is. personally I prefer to initialize the variables to an initial value to make it clear what their default is. That said, this comes with a cost in case of a 0 or NULL initialization since the compiler has to store extra code to do so. Not doing an explicit initialization saves code size in this case. The general kernel recommendation is to not initialize and I am fine with following that one. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
