2010/10/12 Jose Antonio Santos Cadenas <santoscadenas@xxxxxxxxx>: > 2010/10/12 Johan Hedberg <johan.hedberg@xxxxxxxxx>: >> Hi Jose, >> >> On Tue, Oct 12, 2010, Jose Antonio Santos Cadenas wrote: >>> I'm sorry but I can't connect to the IRC rigth now. Nevertheless, I >>> think that I've found the issues: >>> >>> - The iochannel should be unrefereed when the watcher is explicitly removed >> >> Yes, though do you need to have a reference at all? As long as you have >> the GLib watch callback GLib itself holds a reference, so if you don't >> need one just remove chan->echo_chan and do an unref after calling >> add_watch. > > Sorry I've forgot this one. Gonna solve it. Solved, I've removed the chan->echo_chan attribute and directly unref the io_channel once the watcher is set. > >> >>> - The commit message s/paramter/parameter >>> >>> Are there any more? >> >> s/Imcoming/Incoming/ >> s/DBus/D-Bus/ >> >> And the following doesn't make much sense to me: >> >> "Delete all channels DBus interface when the instance is removed" >> >> Could you rephrase it somehow, maybe by putting most of it in the >> message body instead of the summary line. Is it trying to say "Delete >> the D-Bus interfaces of all channels"? The summary line shouldn't be too >> complex. You can just say "Fix D-Bus channel removal when removing >> instances" and then in the message body do the more detailed >> explanation. >> >> Johan >> > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
