Hi Oleg, > >I find your patch actually highly complicated. So I tried to capture > >your intend the in the attached patch (only compiled test) and it would > >be good if you can try that. > > Marcel, your fix is mode delicate compared to original and has same functionality. > > There's small problem with both yours & Rons - there's no error handling for case when other device will never ACK's unsniff - you pretty much DOS session if there's no reply. No real HS will do that but it may present security flaw. I do not know how severe is that > > I attached original conversation when we 1st time seen the problem. is there really a problem? The LMP will send an error via HCI. So we do get the mode changed event, but just with an error. And since we are not checking the error at all, we just go ahead with the SCO setup attempt in that case. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
