RE: [PATCH] Don't handle Changed Combination Link Key for a temporary keys.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yes. That's exactly this situation. 

Thanks,
/Waldek



-----Original Message-----
From: Johan Hedberg [mailto:johan.hedberg@xxxxxxxxx] 
Sent: Wednesday, June 16, 2010 12:26 PM
To: Rymarkiewicz Waldemar
Cc: linux-bluetooth@xxxxxxxxxxxxxxx; par-gunnar.p.hjalmdahl@xxxxxxxxxxxxxx
Subject: Re: [PATCH] Don't handle Changed Combination Link Key for a temporary keys.

Hi,

On Wed, Jun 16, 2010, Waldemar.Rymarkiewicz@xxxxxxxxx wrote:
> Patch on behalf of ST-Ericsson SA
> 
> This patch prevents from storing Changed Combination Link Key type for 
> temporary keys.  Getting Changed Combination Link Key remote auth 
> requirements are already set to 0xff (bonding has finished) and that 
> lets the system to store the key type of Changed Combination (0x06). 
> For temporary keys we don't have to care about Change Link Key event.
> ---
>  src/dbus-hci.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)

Thanks for the patch. It has been pushed upstream. In the future please fix your git author name since it was set to your email address (I fixed it manually this time).

Just to get this clear, this takes care of the situation where we had a link key with a "No Bonding" requirement and get a renewed key for the connection in which case we should still honor the no bonding requirement by not storing the renewed key, right? That's the only other type of "temporary" link key that I can think of in addition to debug keys (which we already take care of).

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux