On Thu, Jun 10, 2010 at 04:48:58PM +0300, Luiz Augusto von Dentz wrote:
> I would just rework it a bit to make the tmp_records to always store
> the last search, something like the following:
>
> - if (device->tmp_records && req->records) {
> + if (device->tmp_records)
> sdp_list_free(device->tmp_records,
> (sdp_free_func_t) sdp_record_free);
> - device->tmp_records = req->records;
> - req->records = NULL;
> - }
> +
> + device->tmp_records = req->records;
> + req->records = NULL;
>
> if (!req->profiles_added && !req->profiles_removed) {
> DBG("%s: No service update", device->path);
> @@ -1522,7 +1522,7 @@ send_reply:
>
> if (dbus_message_is_method_call(req->msg, DEVICE_INTERFACE,
> "DiscoverServices"))
> - discover_services_reply(req, err, req->records);
> + discover_services_reply(req, err, device->tmp_records);
> else if (dbus_message_is_method_call(req->msg, ADAPTER_INTERFACE,
> "CreatePairedDevice"))
> create_device_reply(device, req);
>
> What do you think?
Thanks, that looks good, I'll use that.
What is the procedure to get it included in future versions of BlueZ ?
Does someone sweep this list for patches to review and possibly
include ?
Thanks.
-tpr
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
