Hi, On Tue, Mar 9, 2010 at 9:31 AM, Nick Pelly <npelly@xxxxxxxxxx> wrote: > On Mon, Mar 8, 2010 at 11:19 PM, Ville Tervo <ville.tervo@xxxxxxxxx> wrote: >> Tervo Ville (Nokia-D/Helsinki) wrote: >>> >>> l2cap socket status might change while rfcomm is processing frames. And >>> that makes rfcomm_process_rx to do double rfcomm_session_put() for incoming >>> session reference. We cannot use sk_state. >>> >>> Could you try with this patch if it helps to your problems also? My OPP >>> problems went away with this patch. >>> >>> I moved rfcomm_session_put() for incoming session to rfcomm_session_close >>> in order to get more clear _hold()/_put() pairs. >>> >>> >> >> Any comments about the patch in previous mail? > > Your patch looks sane to me, although I know enough of the Bluez > rfcomm state machine to know that I don't know it that well :) We have tested this patch and it looks to be working. Shall we apply it? Regards, Andrei -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html