Hi Tomas, > > > use strict_strtoul as suggested by checkpatch.pl > > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > > --- > > > V2: > > > 1. more verbose commit message > > > 2. return the error code that was produced by strict_strtoul > > > > why do you bother actually. Reading the comment about struct_strtoul it > > will only return -EINVAL or 0. So using my proposal would be just fine. > > I also don't prefer to differ the return value to user space until it > > actually makes sense. Invalid argument is just fine for all error cases. > > > Yes I know but I've use of this over the kernel code and what I've used is the mostly used idiom I choose to have it as I originally proposed. Patch has been pushed into bluetooth-testing tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
