> -----Original Message----- > From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx] > Sent: Tuesday, March 09, 2010 10:42 PM > To: Winkler, Tomas > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Cohen, Guy; Rindjunsky, Ron > Subject: Re: [bluetooth-next V2] bluetooth: hci_sysfs: use strict_strtoul > instead of simple_strtoul > > Hi Tomas, > > > use strict_strtoul as suggested by checkpatch.pl > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > --- > > V2: > > 1. more verbose commit message > > 2. return the error code that was produced by strict_strtoul > > why do you bother actually. Reading the comment about struct_strtoul it > will only return -EINVAL or 0. So using my proposal would be just fine. > I also don't prefer to differ the return value to user space until it > actually makes sense. Invalid argument is just fine for all error cases. > Yes I know but I've use of this over the kernel code and what I've used is the mostly used idiom Thanks Tomas --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ��.n��������+%������w��{.n�����{��� �^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�m
