Re: [PATCH] Don't pass down NULL path to dbus if no modem.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Jan 11, 2010, Zhu Yanhai wrote:
> index 2778cfc..2970e43 100644
> --- a/audio/telephony-ofono.c
> +++ b/audio/telephony-ofono.c
> @@ -579,6 +579,11 @@ static void list_modem_reply(DBusPendingCall *call, void *user_data)
>  						modem_obj_path);
>  		dbus_message_iter_next(&sub);
>  	}
> +	if (modem_obj_path == NULL)
> +	{
> +		debug("no modem found.\n");	
> +		goto done;
> +	}

Functionally the patch seems fine, but could you fix a few coding style
issues please:

 * empty line before the if-statement
 * opening { on the same line as the if statement
 * no \n in the debug statement (that gets added automatically).
 * Remove whitespace from the end of the debug line (right now you have
   a tab after the semicolon)

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux