Hi Marcel,
Thanks for reviewing our patches.
> Hi Bing,
>
> > This driver provides basic definitions and library functions to
> > support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT
> > combo chip.
>
> we still have to talk about the handling of vendor commands. Handling
> these inside the driver is a bad idea. We can just let the core forward
> them to you if you are interested. I have to think about it a little
> bit.
I don't know how the vendor specific commands can be handled outside of btmrvl.ko driver.
Please share with me once you have any idea on the handling of the vendor commands.
> > +struct btm_thread {
> > + struct task_struct *task;
> > + wait_queue_head_t wait_q;
> > + void *priv;
> > +};
>
> Please prefix everything with btmrvl_* for cleaner namespace. Especially
> for the exported symbol it is important that you have a clean namespace.
I've made this change. Do you want me to resend the new patch now, or wait a while for more feedbacks?
>
> Regards
>
> Marcel
>
Thanks,
Bing
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
