Re: [PATCH 1/4 v2] bluetooth: add btmrvl driver to support Marvell bluetooth devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bing,

> This driver provides basic definitions and library functions to
> support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT
> combo chip.

we still have to talk about the handling of vendor commands. Handling
these inside the driver is a bad idea. We can just let the core forward
them to you if you are interested. I have to think about it a little
bit.

> +struct btm_thread {
> +	struct task_struct *task;
> +	wait_queue_head_t wait_q;
> +	void *priv;
> +};

Please prefix everything with btmrvl_* for cleaner namespace. Especially
for the exported symbol it is important that you have a clean namespace.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux