Re: duplicate L2CAP connection requests - before and after L2CAP information response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nick,

> > I think your kernel is wrongly patched. Don't cherry-pick patches that
> > you don't know the impact of.
> 
> Thanks for testing,
> 
> I've narrowed it down. The rogue patch is in fact ours:
> 
> @@ -916,8 +916,8 @@ static inline void hci_conn_complete_evt(struct
> hci_dev *hdev, struct sk_buff *s
>                 }
>         }
> 
> +       hci_proto_connect_cfm(conn, ev->status);
>         if (ev->status) {
> -               hci_proto_connect_cfm(conn, ev->status);
>                 hci_conn_del(conn);
>         }
> 
> This patch was motivated by a discussion in an earlier thread - see
> conn->state vs conn->sk->sk_state.
> 
> Sorry for the false alarm, I was not initially suspicious of this
> patch because it was not in l2cap.c.

I commented on that one and gave you a proper patch which is also in
bluetooth-testing.git ;)

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux