Hi! >>>> _urb_free is an alias for kfree... making code longer & harder to >>>> read. Remove it. >>> >>> our own URB handling here is broken anyway. It was a bad idea when we did >>> it, but at that time the USB susbsystem was not in that good shape that >>> it >>> is today. So I would say leave this code as it is and concentrate on the >>> new btusb driver, but if it helps anybody I am happy to ACK this one. >> >> It currently corrupts memory (use after free) during suspend, and I'm >> trying to get that fixed. It is 90% reproducible. > > that is good, because I can't reproduce it with any of my system. Don't ask > me why. I really simply works. So if you figure it out, it would be great. There needs to be some load on the usb. I use rsync-over-bt-over-gprs/umts. >> It could be easily fixed by just not freeing the urbs during >> disconnect (introducing very very slow memory leak). Would that be >> acceptable? > > I don't think so. > > Have you ever tried btusb driver? That code is a lot cleaner and it uses > USB anchors for the queued URBs (no home grown broken URB queues). I wish I knew about this one earlier. Yes, it seems to work for me. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
