On Fri 2008-04-18 23:07:10, Marcel Holtmann wrote: > Hi Andrew, > >> From: Pavel Machek <pavel@xxxxxx> >> >> _urb_free is an alias for kfree... making code longer & harder to >> read. Remove it. > > our own URB handling here is broken anyway. It was a bad idea when we did > it, but at that time the USB susbsystem was not in that good shape that it > is today. So I would say leave this code as it is and concentrate on the > new btusb driver, but if it helps anybody I am happy to ACK this one. It currently corrupts memory (use after free) during suspend, and I'm trying to get that fixed. It is 90% reproducible. And yes, fixing clean code is easier. It could be easily fixed by just not freeing the urbs during disconnect (introducing very very slow memory leak). Would that be acceptable? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
