Re: [PATCH blktests 5/9] scsi/004: allow to run with built-in scsi_debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Apr 18, 2023 / 20:18, Chaitanya Kulkarni wrote:
> On 4/17/23 05:59, Shin'ichiro Kawasaki wrote:
> > From: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> >
> > To allow the test case run with build-in scsi_debug, replace
> > '_have_module scsi_debug' with _have_scsi_debug, and replace
> > _init_scsi_debug with _configure_scsi_debug.
> >
> > Also, save and restore the values of scsi_debug parameters 'opts' and
> > 'ndelay'. The test case modifies the parameters and do not restore their
> > original values. It is fine when scsi_debug is loadable since scsi_debug
> > is unloaded after the test case run. However, when scsi_debug is built-
> > in, the modified parameters may affect following test cases. To avoid
> > potential impact on following test cases, save original values of the
> > parameters and restore them at the end of the test case.
> >
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> > ---
> >
> 
> Perhaps we should look into a helper to record other default
> parameters before the testcase and restore it after when
> it is built in ?

Hi Chaitanya, thanks for the review comments. Your idea sounds good. I will try
to implement it.

> 
> Irrespective of that, looks good.
> 
> Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
> 
> -ck
> 
> 



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux