Re: [PATCH v2 blktests] don't require modular null_blk for fault-injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Apr 18, 2023 / 21:37, Shin'ichiro Kawasaki wrote:
> On Apr 16, 2023 / 13:37, Akinobu Mita wrote:
> > This blktests change changes null_blk fault-injection settings to be
> > configured via configfs instead of module parameters.
> > This allows null_blk fault-injection tests to run even if the null_blk is
> > built-in the kernel and not built as a module.
> > 
> > If the null_blk does not yet support configuring fault-injection via
> > configfs, fall back to set up with module parameter.
> > 
> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> > ---
> > * v2
> > - don't skip the tests on older kernels without fault-injection via configfs
> 
> Thanks for this v2 patch. It looks good to me. I'll wait a few more days before
> I apply it in case anyone has some more comments.
> 
> One nit in the commit title: it's the better to have the prefix
> "block/{014,015,030}: " to clarify the test cases this commit touches. I'll do
> the edit when I apply this patch.

I've applied the patch with the edit. Thanks!



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux