On 4/18/23 21:50, Christoph Hellwig wrote:
On Tue, Apr 18, 2023 at 03:39:54PM -0700, Bart Van Assche wrote:
+/**
+ * blk_rq_is_seq_zoned_write() - Whether @rq is a zoned write for which the order matters.
Maybe:
* blk_rq_is_seq_zoned_write() - check if @rq needs zoned write serialization
That looks better to me :-)
+bool blk_rq_is_seq_zoned_write(struct request *rq)
+{
+ switch (req_op(rq)) {
+ case REQ_OP_WRITE:
+ case REQ_OP_WRITE_ZEROES:
+ return blk_rq_zone_is_seq(rq);
+ case REQ_OP_ZONE_APPEND:
+ default:
The REQ_OP_ZONE_APPEND case here is superflous.
Agreed, but I'd like to keep it since last time I posted this patch I
was asked whether I had perhaps overlooked the REQ_OP_ZONE_APPEND case.
I added "case REQ_OP_ZONE_APPEND:" to prevent such questions. Are you OK
with keeping "case REQ_OP_ZONE_APPEND:" or do you perhaps prefer that I
remove it?
Bart.
